Ticket #90 (new defect)

Opened 7 months ago

Last modified 2 months ago

Refine SConstruct `BOOST_APPEND` setting.

Reported by: jbronn Owned by: artem
Priority: critical (top) Milestone:
Component: Core Library Version: SVN Trunk
Severity: Blocker Keywords: scons boost mac osx
Cc: Patch Needs Improvement: no
Needs Docmentation: no Has Patch?: yes
Design Decision Needed: no

Description

When specifying BOOST_TOOLKIT the -mt flag was being put in the wrong order -- this fixes that. Moreover, the -mt flag and BOOST_TOOLKIT setting are set once in BOOST_APPEND, which is then subsequently used by the dependency routines. I've also added in some autodection logic for Boost 1.35 so that the extra dependencies for OSX are automatically added (is this required for any other platforms w/1.35 or must OSX?).

I've successfully tested (rundemo.py) with both debug and non-debug builds on OSX 10.5 using both Boost 1.34.1 and 1.35.

Attachments

boost_append_osx_patch.diff (6.7 kB) - added by jbronn 7 months ago.
Fix for compiling mapnik on OSX with Boost 1.35.
boost_append_osx_patch_v2.diff (8.9 kB) - added by jbronn 3 months ago.
Updated version of this patch, refines BOOST_APPEND further by using correct ordering of components.
boost_append_osx_patch_v3.diff (8.9 kB) - added by jbronn 4 days ago.
Updated so that patch applies cleanly after changes in r748.

Change History

Changed 7 months ago by jbronn

Fix for compiling mapnik on OSX with Boost 1.35.

Changed 3 months ago by jbronn

Updated version of this patch, refines BOOST_APPEND further by using correct ordering of components.

Changed 3 months ago by jbronn

The BOOST_TOOLKIT compile time setting is not enough. In order to allow construction of the Boost libraries you have to take into account toolkit, version, and abi flag. The second version corrects the Boost library naming scheme and updates for latest mapnik version.

Thus, when helping out those trying to install it will as simple as instructing them to add BOOST_VERSION=1_35 BOOST_TOOLKIT=gcc to their scons line.

Changed 2 months ago by springmeyer

  • priority set to critical (top)

Changed 2 months ago by springmeyer

  • severity changed from Normal to Blocker

Changed 2 months ago by springmeyer

  • has_patch set
  • patch_need_improvement unset
  • need_documentation unset
  • design_decision_needed unset

Changed 4 days ago by jbronn

Updated so that patch applies cleanly after changes in r748.

Note: See TracTickets for help on using tickets.