Ticket #60 (closed task: fixed)

Opened 3 years ago

Last modified 8 months ago

XML: Make 'width', 'height' and 'type' attributes optional

Reported by: david Owned by: artem
Priority: normal Milestone: 0.7.0
Component: Core Library Version:
Severity: Normal Keywords: XML
Cc: openstreetmap@… Patch Needs Improvement: no
Needs Docmentation: no Has Patch?: no
Design Decision Needed: no

Description

The image loader can figure it out itself ...

Change History

Changed 3 years ago by david

  • owner changed from artem to david

Changed 3 years ago by david

  • summary changed from XML: Remove 'width', 'height' and 'type' image attributes to XML: Make 'width', 'height' and 'type' attributes optional

Changed 2 years ago by springmeyer

  • priority set to normal

David, Can you explain how this would work. Do you mean for graphics loaded as symbols? If so I think we should try to make this ticket more explicit to the symbolizers it would affect.

thanks.

Changed 2 years ago by twain

  • status changed from new to assigned
  • cc openstreetmap@… added
  • patch_need_improvement unset
  • need_documentation unset
  • owner changed from david to twain
  • has_patch unset
  • design_decision_needed unset

In progress for point symbolizer - will see if also applicable to shield symobolizer

Changed 21 months ago by springmeyer

Brian,

Any progress on this?

Dane

Changed 21 months ago by springmeyer

Also see Ticket #155

Changed 20 months ago by springmeyer

  • version set to SVN Trunk
  • milestone set to 0.6.0

Changed 20 months ago by springmeyer

  • milestone changed from 0.6.0 to 1.0.0

Just noticed this key discussion here: https://lists.berlios.de/pipermail/mapnik-users/2008-January/000571.html

Pushing to 1.0.0 unless anyone has solutions to propose soon...

Changed 16 months ago by Ldp

That discussion points to 2 different ideas:

1) Removing width/height. Obviously, Andy's example has value in it, and removing shouldn't be necessary. What should be done, is that if no width/height is set in the symbolizer, the image loader will 'figure it out itself', but if they are set, then the old behaviour should be kept, and the symbol size would be cut or extended, to fit the explicitly given dimensions.

2) Cutting out a symbol from a big sheet of symbols. Interesting idea, but wouldn't it merit a ticket of its own, and not be confused with 1) ?

Changed 8 months ago by Ldp

Since this is now done in trunk, there is good value to backporting this to 0.7.0 as well.

Changed 8 months ago by Ldp

  • version SVN Trunk deleted
  • milestone changed from 1.0.0 to 0.7.0

Changed 8 months ago by artem

  • owner changed from twain to artem
  • status changed from assigned to new

Changed 8 months ago by artem

  • status changed from new to closed
  • resolution set to fixed

Implemented in r1543. NOTE: this is not a backport from 0.8.0 (different logic)

Note: See TracTickets for help on using tickets.