Ticket #173 (closed defect: fixed)

Opened 20 months ago

Last modified 19 months ago

Accept multi-line SQL queries in table parameter

Reported by: migurski Owned by: springmeyer
Priority: critical (top) Milestone: 0.6.0
Component: PostGIS Input Driver Version: 0.5.1
Severity: Normal Keywords:
Cc: Patch Needs Improvement: no
Needs Docmentation: no Has Patch?: no
Design Decision Needed: no

Description

Currently, it seems necessary to pre-process SQL by removing line breaks.

Change History

Changed 20 months ago by springmeyer

  • owner changed from artem to springmeyer

Migurski, I'm interested in looking into this.

What error's do you get currently, or does mapnik fail silently to render when postgres queries fail?

Changed 20 months ago by migurski

I don't see an error, but I see behavior consistent with mapnik ignoring any parts of the query after the first line break.

Changed 19 months ago by springmeyer

Hmm, mike even with crazy multiline queries like in this test mapfile: http://mapnik-utils.googlecode.com/svn/sandbox/multiline_tests/ the mapnik postgis plugin seems to render fine.

Any chance you could post a query gone wrong?

Also, would be great if you could rebuild mapnik with DEBUG=True and then check out the query that mapnik outputs...

ie, based on that example above this is one query that mapnik prints in debug output and it works for me:

select asbinary(the_geom) as geom from (select                                * from world where 
      cntry_name
      = 'Germany')                                                      as 
      
      
      world
      
      
      
 where the_geom && setSRID('BOX3D(-180 -90,180 83.62359619140619)'::box3d,4326)
}}

Changed 19 months ago by artem

  • status changed from new to closed
  • resolution set to fixed
  • component changed from XML to PostGIS Input Driver

fixed in r862

Note: See TracTickets for help on using tickets.