Ticket #111 (new defect)

Opened 3 months ago

Last modified 8 weeks ago

memory_dataset mostly broken (patch needed for simple data-point display)

Reported by: lwu Owned by: artem
Priority: critical (top) Milestone:
Component: Core Library Version:
Severity: Critical Keywords:
Cc: springmeyer Patch Needs Improvement: no
Needs Docmentation: no Has Patch?: yes
Design Decision Needed: yes

Description

In order to implement a simple point_datasource class, one may inherit publicly from memory_datasource.

For example, like so: http://gist.github.com/6150

however, this code relies on the mapnik::memory_datasource to actually do what it's supposed to, that is, provide a query method via memory_datasource::features(const query& q).

Feature query is implemented in terms of mapnik::memory_featureset(), but the next() iterator functionality was commented out a year ago, most likely due to geometric data structure re-structuring.

The patch should be attached. This has been tested to work, and to support the use case of point_datasource (as mentioned previously).

Attachments

mem_featureset.patch (0.9 kB) - added by lwu 3 months ago.
Patch to re-enable memory_datasource fn (specifically commented out iterator code)

Change History

Changed 3 months ago by lwu

Patch to re-enable memory_datasource fn (specifically commented out iterator code)

Changed 3 months ago by lwu

  • summary changed from memory_dataset mostly broken to memory_dataset mostly broken (patch needed for simple data-point display)

Changed 8 weeks ago by springmeyer

  • priority set to critical (top)
  • severity changed from Major to Critical

Changed 8 weeks ago by springmeyer

Does the patch with Ticket #113 supersede this one?

Changed 8 weeks ago by springmeyer

  • cc springmeyer added

Changed 8 weeks ago by springmeyer

  • has_patch set
  • patch_need_improvement unset
  • need_documentation unset
  • design_decision_needed set
Note: See TracTickets for help on using tickets.